-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add secrets manager client factory #1007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks ok, just add docs, as we have for every client quite generic doc page
@pgressa I am going to merge this PR for now. I want to develop further the integration with secret manager for distributed configuration similar AWS Parameter store and it will need to be |
Hey @sdelamo , I am looking to load some DB credentials from AWS secrets manager to use in my lambda function that is built with Micronaut. I noticed that the guide here only talks about the AWS parameters store. This PR seems close to what I need. Do you have any insights on whether this is possible at the moment and if so any guide for achieving what I am after? Thanks in advance! 😃 |
It is currently not possible but I want to add that capability in the short term. We have an issue for it. #1006 Please upvote it if you are interested. |
Awesome! I will work around this for the time being, but I am definitely interested in trying it out once it's out! Make sure you include some docs in there when you are done 😄 🙏 Do you have any sort of timelines in your mind by any chance? |
I would like to get it done in the short term. |
see: #1006
see: https://aws.amazon.com/secrets-manager/