Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secrets manager client factory #1007

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Mar 30, 2021

@sdelamo sdelamo added the type: enhancement New feature or request label Mar 30, 2021
@sdelamo sdelamo requested a review from pgressa March 30, 2021 10:09
aws-sdk-v2/build.gradle Outdated Show resolved Hide resolved
@sdelamo sdelamo requested a review from pgressa March 31, 2021 10:43
Copy link
Contributor

@pgressa pgressa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok, just add docs, as we have for every client quite generic doc page

@pgressa
Copy link
Contributor

pgressa commented Mar 31, 2021

@sdelamo maybe of this PR we could discuss this one #1017 that generates those factories instead of writing them manually.

@sdelamo
Copy link
Contributor Author

sdelamo commented Apr 2, 2021

@sdelamo maybe of this PR we could discuss this one #1017 that generates those factories instead of writing them manually.

@pgressa I am going to merge this PR for now. I want to develop further the integration with secret manager for distributed configuration similar AWS Parameter store and it will need to be @BootstrapContextCompatible.

@sdelamo sdelamo merged commit aaae88c into master Apr 2, 2021
@sdelamo sdelamo deleted the secrets-manager-client branch April 2, 2021 11:56
@athkalia
Copy link

athkalia commented May 8, 2021

Hey @sdelamo , I am looking to load some DB credentials from AWS secrets manager to use in my lambda function that is built with Micronaut. I noticed that the guide here only talks about the AWS parameters store. This PR seems close to what I need. Do you have any insights on whether this is possible at the moment and if so any guide for achieving what I am after? Thanks in advance! 😃

@sdelamo
Copy link
Contributor Author

sdelamo commented May 10, 2021

Do you have any insights on whether this is possible at the moment and if so any guide for achieving what I am after? Thanks in advance! 😃

It is currently not possible but I want to add that capability in the short term. We have an issue for it. #1006 Please upvote it if you are interested.

@athkalia
Copy link

Awesome! I will work around this for the time being, but I am definitely interested in trying it out once it's out! Make sure you include some docs in there when you are done 😄 🙏

Do you have any sort of timelines in your mind by any chance?

@sdelamo
Copy link
Contributor Author

sdelamo commented May 10, 2021

I would like to get it done in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants