Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new configuration asciidoc macro #1594

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Migrate to new configuration asciidoc macro #1594

merged 3 commits into from
Feb 1, 2023

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Jan 31, 2023

closes #1581

@wetted wetted requested a review from sdelamo January 31, 2023 17:31
@wetted wetted mentioned this pull request Jan 31, 2023
Closed
@wetted wetted linked an issue Jan 31, 2023 that may be closed by this pull request
Migrate to new configuration ascidoc macro #1581
Closed
sdelamo
sdelamo approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted the usage of configuration macro in bootstrap.yml. I am not sure about it.

@sdelamo sdelamo merged commit a3c8130 into 3.10.x Feb 1, 2023
@sdelamo sdelamo deleted the config_asciidoc_macro branch February 1, 2023 11:47
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

❌ Java CI failed: https://ge.micronaut.io/s/kq4ieehok4wsi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.9.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to new configuration ascidoc macro
2 participants
@wetted @sdelamo