GH-1442: Handle SecretsManagerException thrown when fetching secrets #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
… when fetching secrets
breader124
changed the title
|
@sdelamo, could you please give it a look? |
sdelamo
approved these changes
Feb 26, 2023
|
Thanks for your contribution. |
sdelamo
pushed a commit
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve GH-1442. I implemented the approach based on gracefully handling and logging all issues that might happen when fetching secrets from AWS Secrets Manager. There are little code changes that IMO do the job. However, the proposed solution based on modifying configuration properties to fetch only specified secrets is still an option. Looking forward for your feedback