fix: start context in MicronautRequestStreamHandler

[sdelamo]

Close: #1913

This PR changes so the MicronautRequestStreamHandler constructor starts the application context, and it invokes inject(this) for the handler to resolve injection points.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[timyates]

Is it worth changing MicronautRequestStreamHandler so it's exactly the same as MicronautRequestHandler?

diff --git a/function-aws/src/main/java/io/micronaut/function/aws/MicronautRequestStreamHandler.java b/function-aws/src/main/java/io/micronaut/function/aws/MicronautRequestStreamHandler.java
index 809c7a3f4..d5dc3f6ae 100644
--- a/function-aws/src/main/java/io/micronaut/function/aws/MicronautRequestStreamHandler.java
+++ b/function-aws/src/main/java/io/micronaut/function/aws/MicronautRequestStreamHandler.java
@@ -55,9 +55,13 @@ public class MicronautRequestStreamHandler extends StreamFunctionExecutor<Contex
      * Lambda deployment.
      */
     public MicronautRequestStreamHandler() {
-        buildApplicationContext(null);
-        startEnvironment(applicationContext);
-        injectIntoApplicationContext();
+        try {
+            buildApplicationContext(null);
+            injectIntoApplicationContext();
+        } catch (Exception e) {
+            LOG.error("Exception initializing handler", e);
+            throw e;
+        }
     }

     /**
@@ -66,8 +70,14 @@ public class MicronautRequestStreamHandler extends StreamFunctionExecutor<Contex
      */
     public MicronautRequestStreamHandler(ApplicationContext applicationContext) {
         this.applicationContext = applicationContext;
-        startEnvironment(applicationContext);
-        injectIntoApplicationContext();
+
+        try {
+            startEnvironment(applicationContext);
+            injectIntoApplicationContext();
+        } catch (Exception e) {
+            LOG.error("Exception initializing handler: " + e.getMessage() , e);
+            throw e;
+        }
     }

     private void injectIntoApplicationContext() {
@@ -91,12 +101,9 @@ public class MicronautRequestStreamHandler extends StreamFunctionExecutor<Contex

     @Override
     protected ApplicationContext buildApplicationContext(Context context) {
-        try {
-            return super.buildApplicationContext(context);
-        } catch (Exception e) {
-            LOG.error("Exception initializing handler: " + e.getMessage(), e);
-            throw e;
-        }
+        applicationContext = super.buildApplicationContext(context);
+        startEnvironment(applicationContext);
+        return applicationContext;
     }

     @NonNull

It might make future comparison easier?

[timyates]

Actually, I think the code suggested above is more correct... It sets this.applicationContext which I cannot see happening in this PR?

[timyates]

Ahhh, I see... that happens in super.buildApplicationContext