Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CustomPojoSerializer adds lambda events pkg #2080

Merged
merged 3 commits into from
Mar 8, 2024
Merged

fix: CustomPojoSerializer adds lambda events pkg #2080

merged 3 commits into from
Mar 8, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Mar 8, 2024

Add a CustomPojoSerializer implementation which includes the package io.micronaut.aws.lambda.events.serde. This package contains @SerdeImport for the AWS Lambda Events classes.

Close: #2048

@sdelamo
fix: CustomPojoSerializer adds lambda events pkg
bbff5e3 
Add a CustomPojoSerializer implementation which includes the package io.micronaut.aws.lambda.events.serde. This package contains `@SerdeImport` for the AWS Lambda Events classes.

Close: #2048
@sdelamo sdelamo added the type: bug Something isn't working label Mar 8, 2024
@sdelamo sdelamo requested a review from dstepanov March 8, 2024 13:12
@sdelamo sdelamo requested a review from timyates March 8, 2024 13:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

timyates
timyates approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdelamo PTAL 5ce6c43

  • I removed the license from the tests
  • I removed @Shared where it wasn't shared between tests
  • The CustomPojoSerializerUtils#getJsonMapper method returns a JsonMapper, not an ObjectMapper... So I changed the return type, and the variables that used it

@sdelamo sdelamo merged commit 9cd35ec into 4.4.x Mar 8, 2024
15 checks passed
@sdelamo sdelamo deleted the 4.4.xpojo branch March 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

@dstepanov dstepanov Awaiting requested review from dstepanov

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
No open projects
4.3.5 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdelamo @timyates