Skip to content

Commit

Permalink
test: tck test for request.getUri() contains query values (#9791)
Browse files Browse the repository at this point in the history
* test: tck test for request.getUri() contains query values

* fix checkstyle
  • Loading branch information
sdelamo committed Aug 29, 2023
1 parent d298f3f commit e29a24e
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

import io.micronaut.context.annotation.Requires;
import io.micronaut.core.annotation.Introspected;
import io.micronaut.core.annotation.Nullable;
import io.micronaut.core.util.CollectionUtils;
import io.micronaut.core.util.StringUtils;
import io.micronaut.http.HttpHeaders;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/*
* Copyright 2017-2023 original authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.micronaut.http.server.tck.tests;

import io.micronaut.context.annotation.Requires;
import io.micronaut.http.HttpRequest;
import io.micronaut.http.HttpStatus;
import io.micronaut.http.annotation.Controller;
import io.micronaut.http.annotation.Get;
import io.micronaut.http.tck.AssertionUtils;
import io.micronaut.http.tck.HttpResponseAssertion;
import io.micronaut.http.uri.UriBuilder;
import org.junit.jupiter.api.Test;

import java.io.IOException;

import static io.micronaut.http.tck.TestScenario.asserts;

@SuppressWarnings({
"java:S5960", // We're allowed assertions, as these are used in tests only
"checkstyle:MissingJavadocType",
"checkstyle:DesignForExtension"
})
public class RequestUriContainsQueryValueTest {

public static final String SPEC_NAME = "RequestUriContainsQueryValueTest";

@Test
void testRequestUriContainsQueryValue() throws IOException {
asserts(SPEC_NAME,
HttpRequest.GET(UriBuilder.of("/requesturi").queryParam("foo", "bar").build()),
(server, request) -> AssertionUtils.assertDoesNotThrow(server, request,
HttpResponseAssertion.builder()
.status(HttpStatus.OK)
.body("/requesturi?foo=bar")
.build()));
}

@Requires(property = "spec.name", value = SPEC_NAME)
@Controller("/requesturi")
static class TestController {
@Get
String index(HttpRequest<?> request) {
return request.getUri().toASCIIString();
}
}
}

0 comments on commit e29a24e

Please sign in to comment.