Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:core:test spends most of the time initializing test classes #6791

Closed
alextu opened this issue Jan 24, 2022 · 2 comments
Closed

:core:test spends most of the time initializing test classes #6791

alextu opened this issue Jan 24, 2022 · 2 comments

Comments

@alextu
Copy link
Contributor

alextu commented Jan 24, 2022

Issue description

:core:test task takes about 1min but the executed tests themselves take about 10s

The bottleneck seems to be ImmutableSortedStringsArrayMapTest spending most of the time in class initialization, Set<String> ABSENT = KEYS - PRESENT seems to be the culprit spending most of the time in metaclass calls. Replacing it with

        KEYS.removeAll(PRESENT)
        ABSENT = KEYS

does the trick and init time is unoticeable. I can submit a PR.
@yawkat
Copy link
Member

yawkat commented Jan 24, 2022

Good catch, please make a PR

alextu added a commit to alextu/micronaut-core that referenced this issue Jan 25, 2022
@alextu
Fix slow test initialization ImmutableSortedStringsArrayMapTest (micr…
5ad0a92 
…onaut-projects#6791)
graemerocher pushed a commit that referenced this issue Jan 25, 2022
@alextu
Fix slow test initialization ImmutableSortedStringsArrayMapTest (#6791)…
0845022 
… (#6799)
@timyates
Copy link
Member

Awesome, fixed by #6799 👍

yawkat pushed a commit that referenced this issue Jun 24, 2022
@alextu @yawkat
Fix slow test initialization ImmutableSortedStringsArrayMapTest (#6791)…
af8133d 
… (#6799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timyates @alextu @yawkat