Include serdeable metadata to internal JSON objects #10526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
graemerocher
approved these changes
Feb 23, 2024
|
I think this PR creates a cycle between Serde and core and that it is a mistake. |
sdelamo
added a commit
that referenced
this pull request
Mar 19, 2024
This pull request adds the HealthResult serialization test introduced in #10526 as a TCK test.
sdelamo
added a commit
that referenced
this pull request
Mar 19, 2024
This pull request adds the JsonError test to verify JsonMapper can deserialize a JsonError as a GenericResource introduced in #10526 as a TCK test.
sdelamo
added a commit
that referenced
this pull request
Mar 20, 2024
This pull request adds the JsonError test to verify JsonMapper can deserialize a JsonError as a GenericResource introduced in #10526 as a TCK test.
sdelamo
added a commit
that referenced
this pull request
Mar 20, 2024
* tck: HealthResult serialization This pull request adds the HealthResult serialization test introduced in #10526 as a TCK test. * Unused imports and whitespace * Try to fix the build... Switching base seems to have broken things --------- Co-authored-by: Tim Yates <tim.yates@gmail.com>
sdelamo
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the examples from micronaut-projects/micronaut-serialization#691
And eliminates the need for a custom deserializer for HealthStatus in Micronaut Serialization