-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setter/getter with a different type #10537
Conversation
Initially, I also wanted to separate annotations into read/write, based on the accessors, but that doesn't really work well with Jackson. I still kept the API in AST. |
defaults, | ||
loadTypeMethods | ||
); | ||
|
||
int typeLocal = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use Supplier.memoized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh probably not more readable though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be more confusing; the invocation is contextual, and if a variable is not needed, we don't create it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this add significant size to the generated introspections?
defaults, | ||
loadTypeMethods | ||
); | ||
|
||
int typeLocal = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh probably not more readable though
...roovy-test/src/main/groovy/io/micronaut/ast/transform/test/AbstractBeanDefinitionSpec.groovy
Outdated
Show resolved
Hide resolved
Not much, considering we generate an additional argument only if the setter/getter value is different (in most cases, it shouldn't), plus it needs to be enabled. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
No description provided.