Let event loop threads implement reactor NonBlocking #10609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the default netty ThreadFactory to have the threads implement reactor NonBlocking. Any reactor blocking operations will then throw when they're done on an event loop thread.
http-netty/src/main/java/io/micronaut/http/netty/channel/NettyThreadFactoryConfiguration.java
Outdated
Show resolved
Hide resolved
|
this will likely break security. in the meeting i suggested we move the security filter to blocking for now. |
|
security is not implemented correctly if it is blocking and if it is blocking needs to be declared as such. |
graemerocher
approved these changes
Mar 18, 2024
sdelamo
requested changes
Mar 19, 2024
http-netty/src/main/java/io/micronaut/http/netty/channel/NettyThreadFactory.java
Show resolved
Hide resolved
sdelamo
approved these changes
Mar 21, 2024
|
This was referenced Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the default netty ThreadFactory to have the threads implement reactor NonBlocking. Any reactor blocking operations will then throw when they're done on an event loop thread.