Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Cloud config server client #1065

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Spring Cloud config server client #1065

merged 1 commit into from
Jan 3, 2019

Conversation

thiagolocatelli
Copy link
Contributor

This is the pull request related to the issue #501, to include the configuration client for Spring Cloud config client.

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2018

CLA assistant check
All committers have signed the CLA.

@graemerocher
Copy link
Contributor

Thanks. I think we have to resolve the lack of tests before merging. But it looks like a good start

@graemerocher
Copy link
Contributor

Sorry the wording on the CLA changed to fix a typo, could you sign again?

@thiagolocatelli
Copy link
Contributor Author

Signed

@MichelSchudel
Copy link
Contributor

@graemerocher you could use the tests in the sample project as a base for an integration test. It includes a mock spring cloud config server: https://github.com/thiagolocatelli/micronaut-spring-client/tree/master/spring-config-sample/src/test/java/com/github/thiagolocatelli

@graemerocher
Copy link
Contributor

Thanks for the pointer

@graemerocher graemerocher self-requested a review January 3, 2019 12:02
@graemerocher graemerocher self-assigned this Jan 3, 2019
@graemerocher graemerocher added this to the 1.1.0 milestone Jan 3, 2019
@graemerocher graemerocher merged commit 854ace0 into micronaut-projects:master Jan 3, 2019
@graemerocher
Copy link
Contributor

Merged with the documentation, improvements and a test (although test coverage could be improved). Thanks for the contribution bfcf63e

@thiagolocatelli
Copy link
Contributor Author

Thank you @graemerocher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants