Implement de/compression in Http2ServerHandler #10660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decompression implemented through DelegatingDecompressorFrameListener because backpressure is a bit awkward otherwise - Compression implemented through custom code because we need it for the compression config options we provide - Merged DecompressionSpec into CompressionSpec - Moved CompressionSpec to micronaut HTTP client (for HTTP/3 support) - Added subclasses of CompressionSpec for HTTP/2 and HTTP/3
|
sdelamo
approved these changes
Mar 28, 2024
| @@ -52,6 +57,8 @@ final class Compressor { | |||
| private final SnappyOptions snappyOptions; | |||
|
|
|||
| Compressor(HttpCompressionStrategy strategy) { | |||
| assert strategy.isEnabled(); | |||
There was a problem hiding this comment.
should we raise a ConfigurationException instead?
There was a problem hiding this comment.
it's only a sanity check, the callers do not invoke the constructor at all in this case
| if (!finished) { | ||
| try { | ||
| compressionChannel.finishAndReleaseAll(); | ||
| } catch (DecompressionException ignored) { |
There was a problem hiding this comment.
should not we log this exception?
There was a problem hiding this comment.
this happens when a user closes a connection so we want to avoid log spam from half-finished data
| @@ -92,6 +108,48 @@ class CompressionSpec extends Specification { | |||
| -1 | 10000 | false | |||
| } | |||
|
|
|||
| def decompression(ChannelHandler compressor, CharSequence contentEncoding) { | |||
| given: | |||
| def ctx = ApplicationContext.run(['spec.name': 'CompressionSpec'] + serverOptions()) | |||
There was a problem hiding this comment.
Suggested change
| def ctx = ApplicationContext.run(['spec.name': 'CompressionSpec'] + serverOptions()) | |
| EmbeddedServer server = ApplicationContext.run(EmbeddedServer, ['spec.name': 'CompressionSpec'] + serverOptions()) |
| def decompression(ChannelHandler compressor, CharSequence contentEncoding) { | ||
| given: | ||
| def ctx = ApplicationContext.run(['spec.name': 'CompressionSpec'] + serverOptions()) | ||
| def server = ctx.getBean(EmbeddedServer).start() |
There was a problem hiding this comment.
Suggested change
| def server = ctx.getBean(EmbeddedServer).start() |
| given: | ||
| def ctx = ApplicationContext.run(['spec.name': 'CompressionSpec'] + serverOptions()) | ||
| def server = ctx.getBean(EmbeddedServer).start() | ||
| def client = ctx.createBean(HttpClient, server.URI).toBlocking() |
There was a problem hiding this comment.
Suggested change
| def client = ctx.createBean(HttpClient, server.URI).toBlocking() | |
| def client = server.applicationContext.createBean(HttpClient, server.URI).toBlocking() |
| cleanup: | ||
| client.close() | ||
| server.stop() | ||
| ctx.close() |
There was a problem hiding this comment.
Suggested change
| ctx.close() | |
| server.close() |
|
|
||
| cleanup: | ||
| client.close() | ||
| server.stop() |
There was a problem hiding this comment.
Suggested change
| server.stop() |
dstepanov
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not scheduled to a project, it can go to 4.4 or 4.5 it doesn't matter