Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSP: Correct replacing annotations #10750

Merged
merged 1 commit into from Apr 22, 2024
Merged

KSP: Correct replacing annotations #10750

merged 1 commit into from Apr 22, 2024

Conversation

dstepanov
Copy link
Contributor

Fixes #10737

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

timyates
timyates approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against the reproducer in #10737 and it works!

🦸

@sdelamo sdelamo merged commit 7223658 into 4.4.x Apr 22, 2024
17 checks passed
@sdelamo sdelamo deleted the kspfi branch April 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees

@dstepanov dstepanov

Labels
None yet
Projects
No open projects
4.4.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dstepanov @timyates @graemerocher @sdelamo