Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensuring the deserialization has access to the ServerRequestContext #10904

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Ensuring the deserialization has access to the ServerRequestContext #10904

merged 2 commits into from
Jun 14, 2024

Conversation

lcavadas
Copy link
Contributor

@lcavadas lcavadas commented Jun 13, 2024 •
edited
Loading

Addressing the issue on #10665

@lcavadas lcavadas changed the title #10665 Ensuring the deserialization has access to the ServerRequestCo… #10665 Ensuring the deserialization has access to the ServerRequestContext Jun 13, 2024
@lcavadas lcavadas changed the title #10665 Ensuring the deserialization has access to the ServerRequestContext Ensuring the deserialization has access to the ServerRequestContext Jun 13, 2024
@dstepanov
Copy link
Contributor

Please add a test

@graemerocher graemerocher requested a review from yawkat June 14, 2024 06:21
@lcavadas
Adding a test to ensure that large request payloads still have access…
27f2116 
… to the ServerRequestContext on deserialization.
@graemerocher graemerocher added the type: bug Something isn't working label Jun 14, 2024
@graemerocher graemerocher merged commit 1ad1d9c into micronaut-projects:4.5.x Jun 14, 2024
12 checks passed
@graemerocher
Copy link
Contributor

Thanks for the contribution!

@lcavadas lcavadas deleted the issue-10665 branch June 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov approved these changes

@yawkat yawkat Awaiting requested review from yawkat

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
4.5.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lcavadas @dstepanov @graemerocher