Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BeanIntrospection to check if null should be suppress #2935

Merged
merged 4 commits into from
Mar 17, 2020

Conversation

sdelamo
Copy link
Collaborator

@sdelamo sdelamo commented Mar 17, 2020

Close: #2933

The tests at BeanIntrospectionModuleSpec already passed without the shouldSuppressNulls fix.

We will need to add a functional test to the Graal tests @ilopmar setup.

Moreover, should I move BeanIntrospectionUtils to a different place?

@graemerocher
Copy link
Contributor

I cleaned up the PR since it over complicated matters a bit

@graemerocher graemerocher added this to the 1.3.4 milestone Mar 17, 2020
@sdelamo
Copy link
Collaborator Author

sdelamo commented Mar 17, 2020

Thanks, I did not know about:

  JsonInclude.Include include = beanProperty.enumValue(JsonInclude.class, JsonInclude.Include.class).orElse(null);
             if (include == null) {
                 include = beanProperty.getDeclaringBean().enumValue(JsonInclude.class, JsonInclude.Include.class).orElse(null);
             }

That simplifies things.

@ilopmar
Copy link
Contributor

ilopmar commented Mar 17, 2020

I'll work on the test application and add it to our pipeline

@graemerocher graemerocher merged commit f353de9 into 1.3.x Mar 17, 2020
@sdelamo sdelamo deleted the issue2933 branch March 17, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introspected POJO which uses Jackson JsonInclude.Include.NON_NULL) does not work with GraalVM
3 participants