Disable route validation on Java 8 incremental (#5236) #5248
Conversation
|
|
| version = version.substring(0, dot); | ||
| } | ||
| } | ||
| return Integer.parseInt(version); |
There was a problem hiding this comment.
This could lead to a NPE if one of the conditions fail. They shouldn't fail, but you never know. Best to wrap in an a try/catch and return -1 if an exception occurs.
|
Thanks, one small change and it can be merged |
|
Thanks! I considered adding a test case to avoid regressions, but I wasn't sure where to start. Are there any tests that exercise incremental compilation that I can use as inspiration? |
|
yeah not really, the incremental part is really hard to test :/ Maybe a test could be written here https://github.com/micronaut-projects/micronaut-gradle-plugin/blob/master/src/test/groovy/io/micronaut/gradle/MicronautLibraryPluginSpec.groovy But it would require us to first release a version of micronaut with this fix |
As discussed in #5236. When the Java 8 compiler loads a compiled class, the method parameters are named arg0, arg1, ... (even though the real names are available in the class file), and the route validation processor incorrectly produces an error. With this PR route validation is skipped when running on Java 8 or lower and incremental compilation is enabled.
Feedback welcome!