Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim element collection in env property #5617

Conversation

eutkin
Copy link

@eutkin eutkin commented Jun 18, 2021

Issue #5615

@CLAassistant
Copy link

CLAassistant commented Jun 18, 2021

CLA assistant check
All committers have signed the CLA.

@eutkin eutkin changed the title ISSUE 5615: Trim element collection in env property Trim element collection in env property Jun 18, 2021
@eutkin eutkin force-pushed the 5615-trim-collection-element-config branch from a206c05 to 8acaedc Compare June 18, 2021 16:30
@jameskleeh
Copy link
Contributor

As I said in the issue I'm not sure we can assume this is the desired behavior. It is easily avoided by simply not putting spaces in the config. This is also not backwards compatible

@jameskleeh jameskleeh changed the base branch from 2.5.x to 3.0.x June 18, 2021 18:42
@osscontributor
Copy link

I see that this has been moved from 2.5.x to 3.0.x. If this is brought into 3.0, will there still be a way to express leading and trailing whitespace in a config value?

@eutkin
Copy link
Author

eutkin commented Jun 22, 2021

I see that this has been moved from 2.5.x to 3.0.x. If this is brought into 3.0, will there still be a way to express leading and trailing whitespace in a config value?

only:

property:
  - 'one'
  - ' two'

@osscontributor
Copy link

@eutkin I see. I didn't run it but from looking at the PR it looked like that probably wouldn't work. Sorry for the noise.

@jameskleeh jameskleeh closed this Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants