Support regex-style patterns in @Filter
#5954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
racevedoo
commented
Aug 9, 2021
core/src/main/java/io/micronaut/core/util/RegexPathMatcher.java
Outdated
Show resolved
Hide resolved
racevedoo
commented
Aug 9, 2021
core/src/main/java/io/micronaut/core/util/RegexPathMatcher.java
Outdated
Show resolved
Hide resolved
jameskleeh
reviewed
Aug 9, 2021
http/src/main/java/io/micronaut/http/filter/HttpFilterResolver.java
Outdated
Show resolved
Hide resolved
jameskleeh
reviewed
Aug 9, 2021
racevedoo
force-pushed
the
filter-annotation-regex
branch
2 times, most recently
from
73034b4
to
f117d5d
Compare
racevedoo
force-pushed
the
filter-annotation-regex
branch
from
f117d5d
to
d050339
Compare
|
@jameskleeh should we wait for a 3.1.x branch before merging this? what's usually done in cases like this? |
|
@racevedoo Yep should be soon |
|
@racevedoo We can merge this now that we have 3.1.x, however this is missing documentation |
Great! I'll add some documentation in this PR |
racevedoo
force-pushed
the
filter-annotation-regex
branch
from
d050339
to
346a0df
Compare
Adds a attribute to the `Filter` annotation, specifying which style of pattern to use, keeping Ant as the default (avoiding breaking changes). Also adds proper documentation. Fixes micronaut-projects#5842
racevedoo
force-pushed
the
filter-annotation-regex
branch
from
346a0df
to
e58cef0
Compare
|
@jameskleeh just added documentation |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a attribute to the
Filterannotation, specifying which style ofpattern to use, keeping Ant as the default (avoiding breaking changes).
Fixes #5842