Fix infinite loop when requesting demand in SingleThreadedBufferingSubscriber #6147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this issue when debugging #6100. It is definitely a bug, but I am not sure yet how important it is to that issue.
Before this patch, requesting data from a
SingleThreadedBufferingSubscriber
when it is inBUFFERING
state would cause an infinite loop.request
first registers the new demand, and then callsflushBuffer
to fulfill some of the new demand using currently buffered data. If there was no previous demand, this happens inBUFFERING
state.flushBuffer
then tries to remove data from the buffer and submit it usingonNext
, until the buffer is empty or there is no more demand. However, inBUFFERING
state,onNext
simply readds the data to the buffer and does not touch the demand, so this is an infinite loop.This fix extracts the "forwarding logic" in
onNext
to its own method, that does not consider the current state.flushBuffer
now uses that method instead ofonNext
.