Mark some properties on Resource classes with their correct property names #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
approved these changes
Sep 30, 2021
yawkat
added a commit
that referenced
this pull request
Mar 24, 2022
Support for JsonNaming was missing (same for the `property-naming-strategy` config property), and support for JsonProperty was spotty. This implements support for both. Also removed some old code that special-cased the property names for `Resource`. Not needed anymore since #6254 Fixes #6904 Fixes #6665 Fixes #7129 Fixes micronaut-security/#946
sdelamo
pushed a commit
that referenced
this pull request
Mar 30, 2022
…7139) Support for JsonNaming was missing (same for the `property-naming-strategy` config property), and support for JsonProperty was spotty. This implements support for both. Also removed some old code that special-cased the property names for `Resource`. Not needed anymore since #6254 Fixes #6904 Fixes #6665 Fixes #7129 Fixes micronaut-security/#946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks some of the properties on Resource, AbstractResource and JsonError using
@JsonProperty. These properties are already special cased inBeanIntrospectionModuleandResourceSerializerModifier, so this has no impact on jackson-based serialization, but it avoids having to implement the special case in generated serializers as well.This change only adds a compileOnly dependency on jackson-annotations.
setLinksandsetEmbeddedhave been marked public so that they can be accessed by deserializers generated for subclasses that are in a different package.setEmbeddedhas its parameter type changed toMap<String, Object>because there can be no generic deserializer forResourceanyway, and it doesn't matter becausesetEmbeddeddoesn't do anything anyway.