Fix sharing of annotation class value loading between introspection and its ref #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
approved these changes
Oct 6, 2021
jameskleeh
added this to In progress
in Micronaut Developers Work Coordination
via automation
jameskleeh
moved this from In progress
to Done
in Micronaut Developers Work Coordination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was introduced by #6217
The
loadTypeMethodsvariable was not cleared between writing the introspection and the ref and thus if both the ref and the introspection needed to load the same class the method would only be written to the ref, but attempt to be called from the introspection.I think ideally we could only have the methods written to the ref, however the current code is not setup for that type of thing at all as far as I can tell. The result is that if both are loading the same class the load method will be duplicated in both classes.