Add JsonMapper-based readMetadataUrl method to ComputeInstanceMetadataResolverUtils #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aResolverUtils This allows loading metadata with only the json-core module. The other methods require jackson-core or jackson-databind.
graemerocher
requested changes
Nov 30, 2021
runtime/src/main/java/io/micronaut/discovery/cloud/ComputeInstanceMetadataResolverUtils.java
Show resolved
Hide resolved
graemerocher
approved these changes
Nov 30, 2021
|
This should go into 3.3 |
|
@jameskleeh normally I would agree but it would be nice if the all the modules were compatible with serialization for the release of Micronaut 3.3. Without this method then AWS module will not work with Micronaut Serialization and is coupled to Jackson until 3.3 is out and we will have to do a patch release of AWS afterwards If you think that is better then we do that, but seems a pretty minor change to wait all the way until 3.3.1 |
yawkat
added a commit
that referenced
this pull request
Jun 24, 2022
…aResolverUtils (#6587) * Add JsonMapper-based readMetadataUrl method to ComputeInstanceMetadataResolverUtils This allows loading metadata with only the json-core module. The other methods require jackson-core or jackson-databind. * since * Update since Co-authored-by: jameskleeh <james.kleeh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows loading metadata with only the json-core module. The other methods require jackson-core or jackson-databind.
Required for micronaut-aws migration.