Clear annotation defaults cache to prevent pollution from one language to another #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have checked this PR fixes errors in Micronaut Data |
|
fails a lot of tests though :/ |
graemerocher
approved these changes
Jan 11, 2022
|
Looks like it fixed some compile errors but then 3.2.5 has introduced other problems. Cases with https://github.com/micronaut-projects/micronaut-data/compare/err |
|
Hmm I guess the changes added between when you verified the PR and it was merged caused the issues |
|
Actually, I have only checked the |
yawkat
pushed a commit
that referenced
this pull request
Jan 21, 2022
…e to another (#6734) * Clear annotation defaults cache to prevent pollution from one language to another * Separate runtime and compile time caches * Copy defaults to runtime for Groovy tests * Use a regular map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also reorders the reference classes to register annotation defaults before creating annotation metadata because the creation references the defaults.