Access log can exclude defined regular expression patterns #6753
Conversation
This change allows the user to specify a list of regular expression patterns that are compiled and matched against the current request URI. If the request URI matches one of them, then the request does not appear in the access log.
...tty/src/main/java/io/micronaut/http/server/netty/handler/accesslog/HttpAccessLogHandler.java
Outdated
Show resolved
Hide resolved
This change allows configuration of a list of regular-expression patterns for tracing. If the current path matches one of these patterns, then tracing is not performed on that request. Follows the same config naming strategy as #6753
This change allows configuration of a list of regular-expression patterns for tracing. If the current path matches one of these patterns, then tracing is not performed on that request. Follows the same config naming strategy as the exclusion of access logs entries in micronaut-projects/micronaut-core#6753
| } else { | ||
| protocol = request.protocolVersion().text(); | ||
| accessLog.exclude(); |
There was a problem hiding this comment.
@graemerocher Would it be safe here to remove the handler from the pipeline? Setting an excluded flag and checking it is extra overhead
There was a problem hiding this comment.
Nice idea!
ctx.pipeline().remove(this);
Seems to work in the test... Checking, and if there's no issues I can find I'll push
There was a problem hiding this comment.
Load tested it with a filtered url and a non-filtered url
ab -k -n 100000 -r -c 5 http://localhost:8080/path/one & ab -k -r -n 100000 -c 5 http://localhost:8080/something
And we didn't get any errors. I'm not a Netty-guru (yet) though, so @graemerocher may know if this is a dangerous thing to be doing
Anyway, pushed the change 👍
There was a problem hiding this comment.
Right, so that doesn't work with keep-alive connections (all logs get dropped after the first excluded one removes the handler from the pipeline)
Reverted back to the field
This reverts commit 3e97cdb.
| @@ -55,6 +57,7 @@ | |||
|
|
|||
| private final Logger logger; | |||
| private final AccessLogFormatParser accessLogFormatParser; | |||
| private final Predicate<String> uriInclusion; | |||
|
@jameskleeh can you merge this before monday so i can fix up #6785 in time for 3.3? |
|
@yawkat Yeah I wasn't sure if you wanted to make the edits on this PR or not. If you're good with it I'll merge |
|
@jameskleeh i don't have any changes to make to this PR. I've put them all in #6785, because they're unrelated to the exclusions feature. |
This change allows configuration of a list of regular-expression patterns for tracing. If the current path matches one of these patterns, then tracing is not performed on that request. Follows the same config naming strategy as the exclusion of access logs entries in micronaut-projects/micronaut-core#6753
* Access log can exclude defined regular expression patterns This change allows the user to specify a list of regular expression patterns that are compiled and matched against the current request URI. If the request URI matches one of them, then the request does not appear in the access log. * Reduce blast radius of my catch-all controller * Update javadoc * Use null instead of calling a truthy predicate * Give the test a proper name * Allow for access logs to be out of order * Pipeline manipulation instead of exclude field for AccessLogger * Undo whitespace changes * Pipeline manipulation fails with keep-alive. Revert to exclude field This reverts commit 3e97cdb.
This change allows the user to specify a list of regular expression patterns that are compiled
and matched against the current request URI.
If the request URI matches one of them, then the request does not appear in the access log.