Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some netty converters to SPI #7952

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Move some netty converters to SPI #7952

merged 3 commits into from
Sep 6, 2022

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Sep 6, 2022

Move some converters from NettyConverters into a new converter registrar that does not require further dependencies from the application context. This allows the registrar to be loaded into the default conversion service with no app context present.

This is a workaround for #7948, and fixes micronaut-projects/micronaut-aws#1452 .

Move some converters from NettyConverters into a new converter registrar that does not require further dependencies from the application context. This allows the registrar to be loaded into the default conversion service with no app context present.

This is a workaround for #7948, and fixes micronaut-projects/micronaut-aws#1452 .
@yawkat yawkat added this to the 3.6.3 milestone Sep 6, 2022
@dstepanov
Copy link
Contributor

Some of the converters that are using conversionService are using convertors from the same class. Maybe we can make them static fields and use them directly or use ConversionServiceDEFAULT? The first option removes an option to override them, but that might be fine.

@yawkat
Copy link
Member Author

yawkat commented Sep 6, 2022

sounds sensible, ive moved the http data converters to the spi class.

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.2% 62.2% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit 83f14c3 into 3.6.x Sep 6, 2022
@sdelamo sdelamo deleted the netty-conversion-spi branch September 6, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants