Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle inner classes in bean import (#8566) #8567

Merged
merged 1 commit into from Jan 19, 2023
Merged

fix: handle inner classes in bean import (#8566) #8567

merged 1 commit into from Jan 19, 2023

Conversation

auke-
Copy link
Contributor

@auke- auke- commented Jan 3, 2023

No description provided.

graemerocher
graemerocher requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@graemerocher graemerocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test

@auke-
Copy link
Contributor Author

auke- commented Jan 19, 2023

needs a test

I've added a test for inner classes to JavaVisitorContextSpec.groovy and BeanImportSpec.groovy

@graemerocher graemerocher added this to the 3.8.2 milestone Jan 19, 2023
@sdelamo sdelamo merged commit 6dfd2fe into micronaut-projects:3.8.x Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@auke- @graemerocher @sdelamo