Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Apache groovy 4.0.9 #8784

Merged
merged 2 commits into from Feb 16, 2023
Merged

build: Apache groovy 4.0.9 #8784

merged 2 commits into from Feb 16, 2023

Conversation

sdelamo
Copy link
Collaborator

@sdelamo sdelamo commented Feb 16, 2023

No description provided.

without @CompilieDynamic

 [Static type checking] - Non-static method java.lang.Object#hashCode cannot be called from static context
 @ line 99, column 16.
           return visitor.getClass().hashCode()
                  ^
@@ -94,6 +95,7 @@ class LoadedVisitor implements Ordered {
return true
}

@CompileDynamic
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without @CompilieDynamic

 [Static type checking] - Non-static method java.lang.Object#hashCode cannot be called from static context
 @ line 99, column 16.
           return visitor.getClass().hashCode()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a regression in Groovy

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is present since 4.0.7

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdelamo sdelamo added the type: dependency-upgrade Upgrade a dependency label Feb 16, 2023
@sdelamo sdelamo added this to the 4.0.0 milestone Feb 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit 80a8749 into 4.0.x Feb 16, 2023
@sdelamo sdelamo deleted the apachegroovy4 branch February 16, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants