Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TemporalAccessor to CharSequence converter #8963

Merged

Conversation

jfsanchez91
Copy link
Contributor

@jfsanchez91 jfsanchez91 commented Mar 17, 2023

Add a better TemporalAccessor to CharSequence converter

  • If the Format annotation is not found in the Annotations Metadata by the ConversionContext, then try first the default DateTimeFormatter already provided before falling back to DateTimeFormatter.RFC_1123_DATE_TIME.

Fixes micronaut-projects/micronaut-cache#404

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023

CLA assistant check
All committers have signed the CLA.

@graemerocher graemerocher self-requested a review March 17, 2023 23:09
@jfsanchez91
Copy link
Contributor Author

jfsanchez91 commented Mar 18, 2023

@graemerocher is it normal for sonar to fail on PRs?

> Task :sonar
Failed to check if project 'micronaut-projects_micronaut-core' is bound
Failed to prepare download of the sensor cache
org.sonar.api.utils.MessageException: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

...
...
...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sonar'.
> Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

@graemerocher
Copy link
Contributor

unrelated problem. Thanks

@graemerocher graemerocher added this to the 4.0.0 milestone Mar 20, 2023
@wetted
Copy link
Contributor

wetted commented Jul 25, 2023

@jfsanchez91 Thank you for this fix.

Can you please merge in the latest changes from the micronaut-core 4.0.x branch and push your branch. Assuming CI passes we'll review and merge the fix.

@wetted wetted added status: needs rebase This pull request needs rebased to another branch status: awaiting feedback and removed status: needs rebase This pull request needs rebased to another branch labels Jul 25, 2023
@sdelamo sdelamo merged commit 088bab2 into micronaut-projects:4.0.x Jul 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
Status: Done
Development

Successfully merging this pull request may close these issues.

Cache Key serialization fails for LocalDateTime parameter type
5 participants