More performance improvements #8993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # http-netty/src/main/java/io/micronaut/http/netty/NettyHttpHeaders.java
i don't think this actually changes perf any but it's still a reasonable change
The map is overkill for this particular case (compared to ConcurrentHashMap) but I think we can use it elsewhere too.
dstepanov
approved these changes
Mar 23, 2023
|
We might want to check all of the concurrent instances we use |
|
fwiw ConcurrentHashMap with a concurrency level of 1 (like in the benchmark) is very close in read perf compared to this new map, and it doesn't have the problem of being very inefficient to populate. so it may be a good choice for some other places like the conversion service. aiui, concurrencyLevel of 1 makes reads faster but concurrent writes slower. |
graemerocher
approved these changes
Mar 24, 2023
|
oh i just realized concurrency level is 1 by default anyway :) so no improvement possible in that area. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New changes from the last PR start at the merge commit.
Only big change is the introduction of a copy on write map, based on HashMap. It's slightly faster than ConcurrentHashMap for reading. I think it will be useful elsewhere too.