Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refreshAndDiff() should handle array values and property placeholders #9312

Merged
merged 3 commits into from
May 25, 2023

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented May 25, 2023

Currently byte[] values (such as secrets) if they are re-read they are not correctly diffed

@graemerocher graemerocher requested a review from yawkat May 25, 2023 14:00
@graemerocher graemerocher added the type: bug Something isn't working label May 25, 2023
@graemerocher graemerocher added this to the 4.0.0 milestone May 25, 2023
@graemerocher graemerocher requested a review from yawkat May 25, 2023 14:18
@graemerocher graemerocher changed the title refreshAndDiff() should handle array values refreshAndDiff() should handle array values and property placeholders May 25, 2023
@graemerocher graemerocher merged commit 83df97c into 4.0.x May 25, 2023
3 of 5 checks passed
@graemerocher graemerocher deleted the config-diff-arrays branch May 25, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants