Fix property caching #9313
Merged
Fix property caching #9313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build broken by #9310. Basically: https://github.com/micronaut-projects/micronaut-core/blob/94f458ac04b0180a989d0cf28984d5e3b5df592f/http-client/src/test/groovy/io/micronaut/http/client/filter/StaticClientFilterSpec.groovy#L24-L28 The resolution of micronaut.server.port used to request the value of test-port as String. With this patch, it requests the value as Object instead (`.getValue(Object.class)`). The caching in PropertySourcePropertyResolver depends on the requested type however, so the Object request (micronaut.server.port) and the String request (micronaut.http.services.a.url) are cached separately and have different computed ports. (Additionally Object request type is not cached at all, but this is not the core issue.) This patch adds another cache *before* conversion that is independent of the requested type. This cache ensures that the value is not recomputed for different request types.
altro3
reviewed
May 26, 2023
inject/src/main/java/io/micronaut/context/env/PropertySourcePropertyResolver.java
Show resolved
Hide resolved
inject/src/main/java/io/micronaut/context/env/PropertySourcePropertyResolver.java
Outdated
Show resolved
Hide resolved
…opertyResolver.java
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build broken by #9310. Basically:
micronaut-core/http-client/src/test/groovy/io/micronaut/http/client/filter/StaticClientFilterSpec.groovy
Lines 24 to 28 in 94f458a
The resolution of micronaut.server.port used to request the value of test-port as String. With this patch, it requests the value as Object instead (
.getValue(Object.class)). The caching in PropertySourcePropertyResolver depends on the requested type however, so the Object request (micronaut.server.port) and the String request (micronaut.http.services.a.url) are cached separately and have different computed ports. (Additionally Object request type is not cached at all, but this is not the core issue.)This patch adds another cache before conversion that is independent of the requested type. This cache ensures that the value is not recomputed for different request types.