Move filters to new API #9357
Merged
Move filters to new API #9357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@graemerocher please wait for tests to pass before merging 😄 I only ran related tests locally. |
|
Kudos, SonarCloud Quality Gate passed! |
graemerocher
added
the
type: improvement
sdelamo
added a commit
that referenced
this pull request
Jun 3, 2023
[`EndpointsFilter`](https://github.com/micronaut-projects/micronaut-core/blob/4.0.x/management/src/main/java/io/micronaut/management/endpoint/EndpointsFilter.java#L44) was marked as @internal in [#9357](#9357). However, Micronaut Security needs to replace/disable that filter. The change to the new filters API forced the replacement in security to be done using the new API. I think we should either remove the @internal or what I think is a more elegant solution, create a marker API to convey Endpoints sensitivity is handled externally and thus the filter should not be loaded. That it is what this PR proposes.
sdelamo
added a commit
that referenced
this pull request
Jun 5, 2023
[`EndpointsFilter`](https://github.com/micronaut-projects/micronaut-core/blob/4.0.x/management/src/main/java/io/micronaut/management/endpoint/EndpointsFilter.java#L44) was marked as @internal in [#9357](#9357). However, Micronaut Security needs to replace/disable that filter. The change to the new filters API forced the replacement in security to be done using the new API. I think we should either remove the @internal or what I think is a more elegant solution, create a marker API to convey Endpoints sensitivity is handled externally and thus the filter should not be loaded. That it is what this PR proposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.