-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: enable binary compatability check #9505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def v = dash > 0 ? version.substring(0, dash) : version | ||
def (major, minor, patch) = v.split('[.]').collect { it.toInteger() } | ||
enabled = major > 4 || (major == 4 && minor > 0) || (major == 4 && minor == 0 && patch > 0) | ||
baselineVersion = "4.0.0-RC3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doe we need to set the baseline version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, so. If I try to build it resolves 3.9.4 and that causes problems with non-existent modules and japiCmp
checks. @melix said we will need to remove it after the 4.0.0 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having some pain getting this to work. I wonder if we need a new build plugin with the fix for |
let me check. I have pushed a fix on |
There are more changes needed. In addition it seems that |
Most likely due to the sonar plugin upgrade in the latest release of build plugins. Apparently the plugin expects a String somewhere but gets a GString. Trying to figure out where... |
Kudos, SonarCloud Quality Gate passed! |
closes #9500