Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: enable binary compatability check #9505

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Jun 27, 2023

closes #9500

@wetted wetted requested a review from melix June 27, 2023 15:09
@wetted wetted self-assigned this Jun 27, 2023
@wetted wetted requested a review from sdelamo June 27, 2023 15:37
@wetted
Copy link
Contributor Author

wetted commented Jun 27, 2023

Copy link
Collaborator

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdelamo sdelamo changed the title enable binary compatability check core: enable binary compatability check Jun 28, 2023
def v = dash > 0 ? version.substring(0, dash) : version
def (major, minor, patch) = v.split('[.]').collect { it.toInteger() }
enabled = major > 4 || (major == 4 && minor > 0) || (major == 4 && minor == 0 && patch > 0)
baselineVersion = "4.0.0-RC3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doe we need to set the baseline version?

Copy link
Contributor Author

@wetted wetted Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, so. If I try to build it resolves 3.9.4 and that causes problems with non-existent modules and japiCmp checks. @melix said we will need to remove it after the 4.0.0 release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wetted
Copy link
Contributor Author

wetted commented Jun 28, 2023

I am having some pain getting this to work. I wonder if we need a new build plugin with the fix for binaryCompatibility. @melix ?

@melix
Copy link
Contributor

melix commented Jun 28, 2023

let me check. I have pushed a fix on micronaut-build but I'll double check nothing else is needed

@melix
Copy link
Contributor

melix commented Jun 28, 2023

There are more changes needed. In addition it seems that micronaut-core supplies the wrong group for the baseline comparator... On it.

@wetted wetted requested a review from sdelamo June 28, 2023 19:22
@sdelamo
Copy link
Collaborator

sdelamo commented Jun 29, 2023

@wetted @melix any idea about the sonar failure which made the build fail?

@melix
Copy link
Contributor

melix commented Jun 29, 2023

Most likely due to the sonar plugin upgrade in the latest release of build plugins. Apparently the plugin expects a String somewhere but gets a GString. Trying to figure out where...

@melix
Copy link
Contributor

melix commented Jun 29, 2023

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sdelamo sdelamo merged commit fcf6f13 into 4.0.x Jun 29, 2023
8 checks passed
@sdelamo sdelamo deleted the enable_binary_compatability branch June 29, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Enable binary compatibility check for 4.0.x branch of Micronaut Core
3 participants