Allow setting of cloud deduction with probes via env vars or property #9508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find a way of testing this (apart from manually)... In the test build script, we set the cloud provider to |
I wrote a unit test 2e8ad83 for the |
sdelamo
approved these changes
Jun 28, 2023
graemerocher
approved these changes
Jun 28, 2023
|
@sdelamo removed the unused import and repetition in the test... |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8068 we disabled probing the OS/network to try and discover the cloud we were running on.
This PR adds an environment variable and property to allow it to be enabled.
Closes #9506