Minor fixes #9596

altro3 · 2023-07-23T12:18:23Z

Javadoc lint fixes
Checkstyle fixes
Some typos fixes
Fixed some tests for different system locale
Fixed minimal java release for inject-test JavaParser
Added '--add-opens java.base/java.lang=ALL-UNNAMED' for correct work SystemLambda and '--add-opens jdk.compiler/com.sun.tools.javac.lang=ALL-UNNAMED' for kotlin in tests
Fixed DefaultFileSystemResourceLoader normalize method for windows

graemerocher · 2023-08-03T07:02:25Z

inject/src/main/java/io/micronaut/inject/ParametrizedProvider.java

- * @author graemerocher
- * @since 1.0
- */
-public interface ParametrizedProvider<T> extends Provider<T> {


this is a breaking change we can't remove it even if it is not used until next major

@graemerocher And how to be? Will this class be present in all releases up to version 5.0 now?

As far as I understand, you forgot to remove it when removed the ParametrizedBeanFactory class.

Anyway I rolled back this change

altro3 · 2023-08-19T05:21:14Z

@sdelamo @dstepanov Hi! Could you review this changes?

sdelamo · 2023-08-21T06:35:46Z

context/src/main/java/io/micronaut/scheduling/executor/ExecutorType.java

@@ -45,7 +45,7 @@ public enum ExecutorType {
    WORK_STEALING,

    /**
-     * @see java.util.concurrent.Executors#newThreadPerTaskExecutor()
+     * @see io.micronaut.scheduling.LoomSupport#newThreadPerTaskExecutor(java.util.concurrent.ThreadFactory)


@yawkat is this change in the javadoc correct?

no. the old one is correct. i assume it triggers a lint failure because it points to a method that is not available on java 17, but that's fine imo.

@yawkat hm... yes, it's true. But why it's Ok if we use java 17 and java 17 doesn't have this method in JDK ?

this setting does not work on java 17 anyway. only on jdks where this method is available does it work.

I wonder if there are such JDKs? ok i will revert this change

sdelamo · 2023-08-21T06:36:28Z

core/src/main/java/io/micronaut/core/io/file/DefaultFileSystemResourceLoader.java

@@ -129,6 +129,9 @@ private static String normalize(String path) {
        }
        if (path.startsWith("file:")) {
            path = path.substring(5);
+            if (path.startsWith("//")) {


Why this change? can you add a test?

Problem with pathes in windows.... Path like this //D:/Wok/.... is wrong

sdelamo · 2023-08-21T06:37:24Z

http-server-netty/src/main/java/io/micronaut/http/server/netty/body/MultiObjectBody.java

@@ -36,7 +36,7 @@
 public sealed interface MultiObjectBody extends HttpBody permits ImmediateMultiObjectBody, ImmediateSingleObjectBody, StreamingMultiObjectBody {
    /**
     * Coerce this value to an {@link InputStream}. This implements
-     * {@link io.micronaut.http.server.netty.binders.InputStreamBodyBinder}. Requires the objects
+     * io.micronaut.http.server.netty.binders.NettyInputStreamBodyBinder. Requires the objects


why remove the @link?

Hm... this is maybe a byg in IDEA. I see now this picture:

But I also don't understand what is wrong...

Reverted

...src/main/java/io/micronaut/http/server/netty/configuration/NettyHttpServerConfiguration.java

...src/main/kotlin/io/micronaut/annotation/processing/test/support/AbstractKotlinCompilation.kt

inject/build.gradle

sdelamo · 2023-08-21T06:39:42Z

jackson-core/src/main/java/io/micronaut/jackson/core/tree/TreeGenerator.java

@@ -167,7 +167,7 @@ public JsonNode getCompletedValue() {
    }

    @Override
-    public void writeStartArray() throws IOException {
+    public void writeStartArray() {


why removing the throws. Does not throw IOException anymore?

You don't need to write exceptions from interface if your implementation don't throw them

jackson-databind/src/main/java/io/micronaut/jackson/databind/JacksonDatabindMapper.java

runtime/build.gradle

2. Checkstyle fixes 3. Some typos fixes 4. Fixed some tests for different system locale 5. Fixed minimal java release for inject-test JavaParser 6. Added '--add-opens java.base/java.lang=ALL-UNNAMED' for correct work SystemLambda and '--add-opens jdk.compiler/com.sun.tools.javac.lang=ALL-UNNAMED' for kotlin in tests 7. Fixed DefaultFileSystemResourceLoader normalize method for windows

@altro3

cherry picked javadocs improvements from @altro3 in #9596

@altro3

Cherry pick parameterized logging improvements from @altro3 in #9596

@altro3

Cherry picked @altro3 changes to SourceVersion in #9596

@altro3

cherry picked javadocs improvements from @altro3 in #9596

@altro3

Cherry picked @altro3 changes to SourceVersion in #9596

@altro3

Cherry pick parameterized logging improvements from @altro3 in #9596

@altro3

Cherry pick changes from @altro3 in #9596 > without it tests doesn't work on Windows and I see exception with SystemLambda

@altro3

* build: open java.lang Cherry pick changes from @altro3 in #9596 > without it tests doesn't work on Windows and I see exception with SystemLambda * Update build.gradle

aop/src/main/kotlin/io/micronaut/aop/util/KotlinInterceptedMethodHelper.kt

...ite-helper/src/main/java/io/micronaut/testsuitehelper/TestGeneratingAnnotationProcessor.java

@altro3

rename variable to avoid name shadowing of outer `result` Originally suggested by @altro3 here: #9596

@altro3

rename variable to avoid name shadowing of outer `result` Originally suggested by @altro3 here: #9596

sdelamo · 2023-11-10T17:02:32Z

Closing this as I think we have incorporated almost every suggestion. @altro3 please reopen separate prs if you think we need them.

altro3 force-pushed the minor_fixes_4.0 branch from 3442ed3 to 61afc17 Compare July 23, 2023 12:21

sdelamo self-assigned this Jul 28, 2023

altro3 force-pushed the minor_fixes_4.0 branch 2 times, most recently from d0258ce to 74e81f9 Compare July 30, 2023 08:08

graemerocher requested changes Aug 3, 2023

View reviewed changes

altro3 force-pushed the minor_fixes_4.0 branch 2 times, most recently from ba448a0 to bb4c76b Compare August 3, 2023 11:44

altro3 requested a review from graemerocher August 3, 2023 15:36

sdelamo reviewed Aug 21, 2023

View reviewed changes

altro3 force-pushed the minor_fixes_4.0 branch 2 times, most recently from ef58fca to 8ac9766 Compare August 21, 2023 14:29

altro3 changed the base branch from 4.0.x to 4.1.x August 21, 2023 14:29

altro3 force-pushed the minor_fixes_4.0 branch from 8ac9766 to 3441ab6 Compare August 21, 2023 14:44

altro3 requested review from yawkat and sdelamo August 25, 2023 04:17

sdelamo added a commit that referenced this pull request Aug 31, 2023

doc: javadoc improvements

791c3f8

cherry picked javadocs improvements from @altro3 in #9596

sdelamo mentioned this pull request Aug 31, 2023

doc: javadoc improvements #9803

Merged

sdelamo added a commit that referenced this pull request Aug 31, 2023

imp: parameterized logging

66860b7

Cherry pick parameterized logging improvements from @altro3 in #9596

sdelamo mentioned this pull request Aug 31, 2023

imp: parameterized logging #9804

Merged

sdelamo added a commit that referenced this pull request Aug 31, 2023

imp: SourceVersion.RELEASE_17

9b81b29

Cherry picked @altro3 changes to SourceVersion in #9596

sdelamo mentioned this pull request Aug 31, 2023

imp: SourceVersion.RELEASE_17 #9805

Merged

sdelamo added a commit that referenced this pull request Aug 31, 2023

doc: javadoc improvements (#9803)

822cf3e

cherry picked javadocs improvements from @altro3 in #9596

sdelamo added a commit that referenced this pull request Aug 31, 2023

imp: SourceVersion.RELEASE_17 (#9805)

b3056cf

Cherry picked @altro3 changes to SourceVersion in #9596

sdelamo added a commit that referenced this pull request Aug 31, 2023

imp: parameterized logging (#9804)

bcee79b

Cherry pick parameterized logging improvements from @altro3 in #9596

sdelamo added a commit that referenced this pull request Aug 31, 2023

build: open java.lang

e9e6ab1

Cherry pick changes from @altro3 in #9596 > without it tests doesn't work on Windows and I see exception with SystemLambda

This was referenced Aug 31, 2023

build: open java.lang #9807

Merged

split assignment in multiple lines #9808

Merged

sdelamo added a commit that referenced this pull request Aug 31, 2023

build: open java.lang (#9807)

abf325c

* build: open java.lang Cherry pick changes from @altro3 in #9596 > without it tests doesn't work on Windows and I see exception with SystemLambda * Update build.gradle

sdelamo added 2 commits September 12, 2023 11:44

Merge branch '4.1.x' into pr/9596

a861b43

Merge branch '4.1.x' into pr/9596

351df41

chalkedgoose reviewed Sep 13, 2023

View reviewed changes

aop/src/main/kotlin/io/micronaut/aop/util/KotlinInterceptedMethodHelper.kt Show resolved Hide resolved

chalkedgoose reviewed Sep 13, 2023

View reviewed changes

...ite-helper/src/main/java/io/micronaut/testsuitehelper/TestGeneratingAnnotationProcessor.java Show resolved Hide resolved

sdelamo added this to the 4.2.0 milestone Nov 10, 2023

sdelamo added a commit that referenced this pull request Nov 10, 2023

imp: avoid name shadowning of result

0e390c9

rename variable to avoid name shadowing of outer `result` Originally suggested by @altro3 here: #9596

sdelamo mentioned this pull request Nov 10, 2023

imp: avoid name shadowning of result #10101

Merged

sdelamo added a commit that referenced this pull request Nov 10, 2023

imp: avoid name shadowning of result (#10101)

e2be0c9

rename variable to avoid name shadowing of outer `result` Originally suggested by @altro3 here: #9596

sdelamo closed this Nov 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor fixes #9596

Minor fixes #9596

altro3 commented Jul 23, 2023 •

edited

Loading

graemerocher Aug 3, 2023

altro3 Aug 3, 2023

altro3 Aug 3, 2023

altro3 commented Aug 19, 2023

sdelamo Aug 21, 2023

yawkat Aug 21, 2023

altro3 Aug 21, 2023 •

edited

Loading

yawkat Aug 21, 2023

altro3 Aug 21, 2023

sdelamo Aug 21, 2023

altro3 Aug 21, 2023

sdelamo Aug 21, 2023

altro3 Aug 21, 2023

sdelamo Aug 21, 2023

altro3 Aug 21, 2023

sdelamo commented Nov 10, 2023

Minor fixes #9596

Minor fixes #9596

Conversation

altro3 commented Jul 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

altro3 commented Aug 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

altro3 Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdelamo commented Nov 10, 2023

altro3 commented Jul 23, 2023 •

edited

Loading

altro3 Aug 21, 2023 •

edited

Loading