-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use supermethod instead of ByteBuffer#clear for binary compatibility #9666
Conversation
Since we build with java >8 but without `-release 8`, `ByteBuffer.clear()` and some similar methods use the new overrides that are not available for java 8. Fixes #9637
@melix ive checked and this configuration detects this failure (and confirms it's fixed): Index: http/build.gradle
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/http/build.gradle b/http/build.gradle
--- a/http/build.gradle (revision b78e7ba8be97f8971b8b83f5fd3883677749ca41)
+++ b/http/build.gradle (date 1691052181820)
@@ -1,6 +1,7 @@
plugins {
id "io.micronaut.build.internal.convention-library"
id "org.jetbrains.kotlin.jvm"
+ id 'ru.vyarus.animalsniffer' version '1.7.1'
}
dependencies {
@@ -19,6 +20,8 @@
testImplementation project(":inject")
testImplementation project(":runtime")
testImplementation(libs.managed.logback)
+
+ signature 'org.codehaus.mojo.signature:java18:1.0@signature'
}
tasks.named("compileKotlin") { do you think we could add something like this to the project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super keen on adding the plugin to detect such issues. 2 reasons:
- we don't know how it behaves in general, it's easy to add a plugin which breaks caching, up-to-date checking, etc...
- we don't need this in Micronaut 4, because we build with the required JDKs
@sdelamo is 3.10.x fine for this or do you think a further backport is necessary? |
Kudos, SonarCloud Quality Gate passed!
|
We probably should backport at least to 3.8.x which is the branch originally mentioned in the issue. |
@yawkat I cherry picked into 3.8.x |
Since we build with java >8 but without
-release 8
,ByteBuffer.clear()
and some similar methods use the new overrides that are not available for java 8.Fixes #9637