Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that HealthMonitoringTask is currently broken. While the periodic task is scheduled according to config, the logic fails to update the CurrentHealthStatus bean.
See example in the added test HealthMonitorTaskSpec.groovy
I found out that the subscriber to reactiveSequence is not getting triggered. It looks like in the
onSubscribe
we have to explicitly callrequest
method so that HealthIndicators would emit HealthResultsIf we fix the above problem with use of
request
we run into another problem.onComplete
in the subscriber reports that the status is UP, even though some checks might be DOWN, and the web endpoints report DOWN. So it looks like incorrect behaviour.This PR proposes a rewrite in a more clear way and fixing the above problems: