Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 9905 websphere deploy war #9906

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

mattmoss
Copy link
Contributor

Fixes #9905

@mattmoss
Copy link
Contributor Author

I have checked on my local machine/docker configuration that the provided patch fixes a Micronaut app as well as a Grails 5.x application.

If you want to try this yourself, let me know and I can provide instructions on running WebSphere in Docker.

@sdelamo
Copy link
Collaborator

sdelamo commented Sep 22, 2023

I have checked on my local machine/docker configuration that the provided patch fixes a Micronaut app as well as a Grails 5.x application.

If you want to try this yourself, let me know and I can provide instructions on running WebSphere in Docker.

provide instructions please

@mattmoss
Copy link
Contributor Author

provide instructions please

WebSphere-Process.pdf

Attached instructions were sent to me and worked for me, with a couple of adjustments annotated.

Some of the docker commands I have here (easier to copy/paste from here, perhaps, than from the pdf)

# Create the container
docker run --name test -h test -v $(pwd)/PASSWORD:/tmp/PASSWORD -p 9043:9043 -p 9443:9443 -p 9080:9080 -d ibmcom/websphere-traditional:latest

# To login to the WebSphere console, use username 'wsadmin'
# Get the password with this (changes daily?)
docker exec -it test cat /tmp/passwordupdated

# Copy war file it to container
docker cp ./build/libs/sample-0.1.war test:/opt/IBM/WebSphere/AppServer/temp

# After copy, look in PDF for how to install and start the war file.

@mattmoss
Copy link
Contributor Author

As a point of info, 3.8.x is needed to support Grails 5.3.x, but these changes should be merged forward as well.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

73.3% 73.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sdelamo sdelamo self-assigned this Sep 25, 2023
@sdelamo sdelamo merged commit 33ecc3b into 3.8.x Sep 25, 2023
11 checks passed
@sdelamo sdelamo deleted the issue-9905-websphere-deploy-war branch September 25, 2023 11:35
sdelamo pushed a commit that referenced this pull request Sep 25, 2023
* Workaround quirks with WebSphere classloader

* Remove nulls from collected bean definition refs

* Fix issue link

* Revert "Remove nulls from collected bean definition refs"

This reverts commit 4846e62.
sdelamo added a commit that referenced this pull request Sep 26, 2023
sdelamo added a commit that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants