Potential fix for count with joins #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
dstepanov
approved these changes
Dec 13, 2022
lcavadas
pushed a commit
to lcavadas/micronaut-data
that referenced
this pull request
Jun 2, 2023
* Potential fix for count with joins * Add more verification to the test * Update AbstractRepositorySpec.groovy * Undo formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #1882
The issue is when there is one to many, so join between 1 author and 2 books loads 2 records which then later gets read into 1 author object and 2 book records in the list. The idea is to skip this join in pageable count query in this case. Not sure if that could introduce other issues (hopefully not) or if there is better fix.