Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testcontainers via test-resources version catalog #2777

Merged
merged 13 commits into from
Feb 7, 2024
Merged

Testcontainers via test-resources version catalog #2777

merged 13 commits into from
Feb 7, 2024

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Feb 2, 2024

No description provided.

@wetted wetted added the relates-to: build label for issues related to the build file or CI label Feb 2, 2024
@wetted wetted self-assigned this Feb 2, 2024
@wetted wetted requested a review from sdelamo February 2, 2024 19:28
sdelamo
sdelamo requested changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, it is important not to change the Gradle configuration. These dependencies should be testImplementation not implementation.

benchmarks/benchmark-spring-data-mongodb/build.gradle Outdated Show resolved Hide resolved
data-connection-jdbc/build.gradle Outdated Show resolved Hide resolved
data-connection-jdbc/build.gradle Outdated Show resolved Hide resolved
data-connection-jdbc/build.gradle Outdated Show resolved Hide resolved
data-connection-jdbc/build.gradle Outdated Show resolved Hide resolved
data-jdbc/build.gradle Outdated Show resolved Hide resolved
data-jdbc/build.gradle Outdated Show resolved Hide resolved
data-jdbc/build.gradle Outdated Show resolved Hide resolved
data-jdbc/build.gradle Outdated Show resolved Hide resolved
data-r2dbc/build.gradle Outdated Show resolved Hide resolved
wetted and others added 12 commits February 5, 2024 09:32
@wetted @sdelamo
Update benchmarks/benchmark-spring-data-mongodb/build.gradle
4d2e87d 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-connection-jdbc/build.gradle
2ff9d3a 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-connection-jdbc/build.gradle
e842569 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-connection-jdbc/build.gradle
318f1c9 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-connection-jdbc/build.gradle
180af1b 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-jdbc/build.gradle
dfbb996 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-jdbc/build.gradle
986e18a 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-jdbc/build.gradle
9879ab2 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-jdbc/build.gradle
66a4819 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-r2dbc/build.gradle
3e2814a 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-connection-jdbc/build.gradle
9cbb8a2 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted @sdelamo
Update data-jdbc/build.gradle
7ef6f4e 
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
@wetted
Copy link
Contributor Author

wetted commented Feb 5, 2024

Please, it is important not to change the Gradle configuration. These dependencies should be testImplementation not implementation.

Thanks for catching that. It was quite unintentional.

@wetted wetted requested a review from sdelamo February 5, 2024 15:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sdelamo sdelamo merged commit f7e9bcc into master Feb 7, 2024
43 checks passed
@sdelamo sdelamo deleted the testcontainers branch February 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees

@wetted wetted

Labels
relates-to: build label for issues related to the build file or CI
Projects
No open projects
4.3.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wetted @sdelamo