fix issue with multi-joins #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
requested changes
Jun 3, 2020
| alias, | ||
| escape ? quote(getColumnName(associatedId)) : getColumnName(associatedId), | ||
| joinColumnNames[0]); | ||
| if (target.indexOf(join.toString()) == -1) { |
There was a problem hiding this comment.
since you are converting the builder to a string at this point it makes sense to use the same converted variable to append to the target otherwise toString() will be called twice which is not super efficient
Also you can make just use target.contains(..) instead
There was a problem hiding this comment.
target is of type StringBuilder, it does not have contains method.
There was a problem hiding this comment.
since you are converting the builder to a string at this point it makes sense to use the same converted variable to append to the target otherwise toString() will be called twice which is not super efficient
I've done the change so that toString() is called only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only appends join if it was not appended before
Close #457