Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take dash into account in activeName matching (#471) #472

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Take dash into account in activeName matching (#471) #472

merged 1 commit into from
Jun 21, 2023

Conversation

FrogDevelopper
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

@FrogDevelopper
Copy link
Contributor Author

locally or in our actions runner, Gradle failed to run, with the error

Could not resolve all files for configuration 'classpath'.
Could not find null:groovydoc-gradle-plugin:null.
Searched in the following locations:
- https://plugins.gradle.org/m2/null/groovydoc-gradle-plugin/null/groovydoc-gradle-plugin-null.pom
- https://repo.maven.apache.org/maven2/null/groovydoc-gradle-plugin/null/groovydoc-gradle-plugin-null.pom
Required by:
unspecified:unspecified:unspecified > io.micronaut.build.shared.settings:io.micronaut.build.shared.settings.gradle.plugin:5.4.4 > io.micronaut.build.internal:micronaut-build:5.4.4 > io.github.groovylang.groovydoc:io.github.groovylang.groovydoc.gradle.plugin:1.0.1

any idea of the reason ?

@@ -6,7 +6,7 @@ pluginManagement {
}

plugins {
id("io.micronaut.build.shared.settings") version "5.4.4"
id("io.micronaut.build.shared.settings") version "5.4.9"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to prevent the error

Could not find null:groovydoc-gradle-plugin:null.

@FrogDevelopper
Copy link
Contributor Author

I got a test in EurekaMockAutoRegistrationSpec failing, without link with my changes

io.micronaut.http.client.exceptions.HttpClientResponseException: Client 'eureka': Failed to decode the body for the given content type [null]

that is annoying

@FrogDevelopper
Copy link
Contributor Author

@alvarosanchez
Sorry, but I don't know why the Sonar build is failing:

Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

Can you have a look, please ?

@alvarosanchez
Copy link
Member

You can ignore the error, it's a known limitation. For security reasons, GitHub Actions won't expose the Sonar secret to repository forks.

@FrogDevelopper
Copy link
Contributor Author

@alvarosanchez
Ok, so I'll let you merge this PR when you want :)

@alvarosanchez alvarosanchez added the type: bug Something isn't working label Jun 21, 2023
@alvarosanchez alvarosanchez merged commit e6ebad6 into micronaut-projects:3.3.x Jun 21, 2023
5 of 6 checks passed
@FrogDevelopper FrogDevelopper deleted the bugfix/471_incorrect-pattern branch June 27, 2023 06:39
FrogDevelopper added a commit to FrogDevelopper/micronaut-discovery-client that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash '-' not working for activeName for Consul PropertySource name
3 participants