Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnyRecipient should work for Micronaut Validation and Micronaut Hibernate Validator #263

Merged
merged 9 commits into from
Jul 21, 2023
Merged

AnyRecipient should work for Micronaut Validation and Micronaut Hibernate Validator #263

merged 9 commits into from
Jul 21, 2023

Conversation

sdelamo
Copy link
Collaborator

@sdelamo sdelamo commented Jul 19, 2023 •
edited
Loading

Close: #259

@sdelamo sdelamo changed the title Issue 259 AnyRecipient should work for Micronaut Validation and Micronaut Hibernate Validator Jul 19, 2023
@sdelamo
Copy link
Collaborator Author

sdelamo commented Jul 19, 2023

Specifying a validator:

@Constraint(validatedBy = AnyRecipientValidator.class)

makes the test pass for hibernate-validator but fail for Micronaut Validation.

@sdelamo sdelamo requested a review from dstepanov July 19, 2023 10:12
@sdelamo sdelamo marked this pull request as ready for review July 19, 2023 10:12
@sdelamo sdelamo added the bug Something isn't working label Jul 19, 2023
@sdelamo sdelamo mentioned this pull request Jul 19, 2023
Closed
@sdelamo sdelamo requested a review from timyates July 20, 2023 13:41
@sdelamo sdelamo requested a review from timyates July 21, 2023 10:42
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sdelamo sdelamo merged commit 916f0a1 into master Jul 21, 2023
7 of 8 checks passed
@sdelamo sdelamo deleted the issue-259 branch July 21, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

@dstepanov dstepanov Awaiting requested review from dstepanov

Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
4.0.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Micronaut Fails to send email if Hibernate Validator is in Classpath
2 participants
@sdelamo @timyates