Allow more than one Reply-To contact in order to be compliant with the Mail RFC #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermocalvo
added
the
type: improvement
sdelamo
requested changes
Jul 21, 2023
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-sendgrid/src/test/groovy/io/micronaut/email/sendgrid/SendgridEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-sendgrid/src/test/groovy/io/micronaut/email/sendgrid/SendgridEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-sendgrid/src/test/groovy/io/micronaut/email/sendgrid/SendgridEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
email-amazon-ses/src/test/groovy/io/micronaut/email/ses/SesEmailComposerSpec.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
…ridEmailComposer.java Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Those two weren't even implementing single "replyTo" address support. I just pushed some changes to make them take "replyTo" into account. |
guillermocalvo
force-pushed
the
217-allow-more-than-one-reply-to-contact-in-order-to-be-compliant-with-the-mail-rfc
branch
from
0e63993
to
1d8a179
Compare
sdelamo
requested changes
Jul 26, 2023
sdelamo
approved these changes
Jul 27, 2023
|
@guillermocalvo can you merge master into this PR. thanks. I will merge it after you have resolved the conflicts. |
…ore-than-one-reply-to-contact-in-order-to-be-compliant-with-the-mail-rfc
|
Kudos, SonarCloud Quality Gate passed! |
sdelamo
approved these changes
Jul 28, 2023
sdelamo
deleted the
217-allow-more-than-one-reply-to-contact-in-order-to-be-compliant-with-the-mail-rfc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multiple
replyToperEmailin a backward-compatible way.Sendgrid does not support multiple 'replyTo' addresses, so we will log a warning.
Closes #217