Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC server doesn't call awaitTermination on shutdown #313

Closed
4 tasks
tandel-pratik opened this issue Feb 12, 2021 · 2 comments
Closed
4 tasks

GRPC server doesn't call awaitTermination on shutdown #313

tandel-pratik opened this issue Feb 12, 2021 · 2 comments

Comments

@tandel-pratik
Copy link

The gRPC server offers a https://grpc.github.io/grpc-java/javadoc/io/grpc/Server.html#awaitTermination-- to ensure that the server is properly terminated. Currently only shutdownNow is being invoked:

It'd be great to add either an option or change default behavior to call awaitTermination with some configurable timeout.

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem uploaded to Github
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. TODO
  2. TODO
  3. TODO

Expected Behaviour

Tell us what should happen

Actual Behaviour

Tell us what happens instead

Environment Information

  • Operating System: TODO
  • Micronaut Version: TODO
  • JDK Version: TODO

Example Application

  • TODO: link to github repository with example that reproduces the issue
@kow3ns
Copy link
Contributor

kow3ns commented Feb 12, 2021

Here is a PR that addresses the issue we found #314

@graemerocher
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants