Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all modules to version catalog. Update lib versions. Added lost protobuf artifacts. #810

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Nov 28, 2023

Fixed #786
Fixed #805

@jeremyg484
Copy link
Contributor

@altro3 Thanks for this, looks good to me. I pushed an additional small change to fix the broken test.

@altro3
Copy link
Contributor Author

altro3 commented Nov 28, 2023

@jeremyg484 You ar ewelcome! I think also need to remove micronaut-discovery-client = '4.1.0' from versions catalog

@jeremyg484
Copy link
Contributor

@jeremyg484 You ar ewelcome! I think also need to remove micronaut-discovery-client = '4.1.0' from versions catalog

@altro3 We are still referencing it in the test-suite-* modules so it needs to stay for the moment. I think it might be safe to remove there as well, but need to sort that out separately.

@jeremyg484 jeremyg484 self-assigned this Nov 28, 2023
@jeremyg484
Copy link
Contributor

@sdelamo Amongst the other cleanup, this PR updates grpc-java to 1.59.1, which was released yesterday and contains the Netty fix we were waiting on. Once merged, it would clear the way for the other version upgrade PR's, such as to Micronaut Platform 4.2.0.

@altro3
Copy link
Contributor Author

altro3 commented Nov 29, 2023

@jeremyg484 Yes, sure. Look to my work with micronaut ;-). I updated version of micronaut to 4.2.0 - now it works fine. Also I removed protobufGradleVersion and now this plugin connecting to example projectsby alias - alias(libs.plugins.protobuf)

@sdelamo sdelamo merged commit 00f0ac8 into micronaut-projects:master Nov 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Micronaut 4.2.0 breaks grpc services Add com.google.protobuf:protobuf-kotlin to Micronaut BOM
3 participants