Mongo sync guide #528
Merged
Mongo sync guide #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
added this to In progress
in Micronaut Developers Work Coordination
via automation
graemerocher
requested changes
Sep 15, 2021
.../micronaut-mongodb-synchronous/java/src/test/java/example/micronaut/FruitControllerTest.java
Outdated
Show resolved
Hide resolved
...cronaut-mongodb-synchronous/java/src/main/java/example/micronaut/MongoDbFruitRepository.java
Outdated
Show resolved
Hide resolved
...cronaut-mongodb-synchronous/java/src/main/java/example/micronaut/MongoDbFruitRepository.java
Outdated
Show resolved
Hide resolved
...cronaut-mongodb-synchronous/java/src/main/java/example/micronaut/MongoDbFruitRepository.java
Outdated
Show resolved
Hide resolved
Micronaut Developers Work Coordination
automation
moved this from In progress
to Review in progress
Sep 15, 2021
guides/micronaut-mongodb-synchronous/java/src/main/java/example/micronaut/Fruit.java
Outdated
Show resolved
Hide resolved
guides/micronaut-mongodb-synchronous/java/src/main/java/example/micronaut/FruitController.java
Outdated
Show resolved
Hide resolved
guides/micronaut-mongodb-synchronous/micronaut-mongodb-synchronous.adoc
Outdated
Show resolved
Hide resolved
guides/micronaut-mongodb-synchronous/micronaut-mongodb-synchronous.adoc
Outdated
Show resolved
Hide resolved
burtbeckwith
approved these changes
Sep 16, 2021
ilopmar
reviewed
Sep 16, 2021
Comment on lines
+25
to
+27
| public void save(@NonNull @NotNull @Valid Fruit fruit){ | ||
| getCollection().insertOne(fruit); | ||
| } |
There was a problem hiding this comment.
Not sure if this is possible or not but I think it would be better if you add an id field to Fruit (probably an UUID) and configure the POJO (or Mongo) to assign it automatically.
There was a problem hiding this comment.
I would prefer to have different POJOs. I would like to use the same POJO for the controller layer and the persistence layer.
There was a problem hiding this comment.
I think we could do this as an improvement after the guide is published.
graemerocher
approved these changes
Sep 16, 2021
Micronaut Developers Work Coordination
automation
moved this from Review in progress
to Reviewer approved
Sep 16, 2021
|
@kroegerk could you do a proofread ? |
Just a couple of minor changes.
sdelamo
added
the
status: awaiting third-party
Micronaut Developers Work Coordination
automation
moved this from Reviewer approved
to Done
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.