Support generation of multi-module guides #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sdelamo
approved these changes
Jan 29, 2021
| if (guidesOption.language == Language.GROOVY) { | ||
| guidesFeatures.remove('graalvm') | ||
| } | ||
|
|
||
| BuildTool buildTool = guidesOption.buildTool | ||
| TestFramework testFramework = guidesOption.testFramework | ||
| Language lang = guidesOption.language | ||
| JdkVersion javaVersion = JdkVersion.JDK_8 |
There was a problem hiding this comment.
do you want us to generate guides with JDK 8 or should we go to 11 ?
There was a problem hiding this comment.
Umm... As we are defaulting apps in Launch to JDK11 I think we should go with 11 here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multi-project guides and migrates the Consul guide to the new publication system. It partially fixes #1. Once this is merged I'll migrate the Jaeger guide that continues from this.
I've also added support to read
skipGradleTestsandskipMavenTestsfrom metadata and default them to false if they are not present. What is missing is modifying the logic to generate the appropriatetesh.shfor multi-projects and take those flags into account.Btw @sdelamo the
.svgfiles are not rendered. Can you please convert them to.png? I've also included the original sketch file for future references so you should be able to export them.