Register the Hibernate validation message bundle #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kevin-wise
commented
Jun 13, 2024
| import jakarta.inject.Singleton; | ||
|
|
||
| @Singleton | ||
| @Requires(bean = MicronautHibernateValidator.class) |
There was a problem hiding this comment.
Would it be better to use this?
Suggested change
| @Requires(bean = MicronautHibernateValidator.class) | |
| @Requires(resources = "classpath:org/hibernate/validator/ValidationMessages.properties") |
…jects#410) so that messages are interpolated correctly
…alidationMessages.properties")`
kevin-wise
force-pushed
the
register-hibernate-message-bundle
branch
from
8808d87
to
78c8ffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register the Hibernate validation message bundle, so that messages are interpolated correctly. Fixes #410 .
I'm not really sure what made this necessary. I do know that it broke between Micronaut 3 and 4.
Of course, I'm open to other ideas. This was the first one I had that worked.