Missing @Singleton #633
Merged
Missing @Singleton #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @agustin-tecso @guillermocalvo please merge master into the branch and add a test. At least verify that context contains the bean. We should have a test which detects this. |
The class needs to be annotated with @singleton so that it can be injected
Reason: io.micronaut.context.exceptions.NoSuchBeanException: No bean of type [io.micronaut.configuration.kafka.docs.producer.fallback.MessageClientFallback] exists. The bean [MessageClientFallback] is disabled because it is within the package [io.micronaut.configuration.kafka] which is disabled due to bean requirements: * Property [kafka.enabled] with value [false] should not equal: false
|
I just added a test to check that the fallback bean exists in the context, and that it behaves as expected. Ironically, I had to move the fallback bean away from the java package |
sdelamo
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class needs to be annotated with @singleton so that it can be injected